Fixes #83. Parsing an invalid conandata.yml now shows the exception m…

…essage to the user
markfinal · Jul 13, 2023 · 7f37d4f · 7f37d4f
1 parent ca627af
commit 7f37d4f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/cruiz/commands/context.py b/cruiz/commands/context.py
@@ -602,7 +602,7 @@ def get_conandata(
             if self.parent():
                 self.parent().record_exception(exception)
             else:
-                raise Exception(
+                raise ValueError(
                     "Failed to get conandata YAML dict for recipe"
                 ) from exception
         return conandata

diff --git a/cruiz/load_recipe/loadrecipewizard.py b/cruiz/load_recipe/loadrecipewizard.py
@@ -67,7 +67,12 @@ def __init__(
             log_details.logging.connect(self._on_error_loading)
             with managed_conan_context(DEFAULT_CACHE_NAME, log_details) as context:
                 self.recipe_attributes = context.inspect_recipe(self._path)
-                self.conandata = context.get_conandata(self._path)
+                try:
+                    self.conandata = context.get_conandata(self._path)
+                except ValueError:
+                    log_details.stderr(
+                        "Unable to obtain version numbers from conandata.yml"
+                    )
 
     def _on_error_loading(self) -> None:
         self.ui.intro_message.show()