Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flatten with encode #514

Closed
wants to merge 1 commit into from

Conversation

tvdeyen
Copy link

@tvdeyen tvdeyen commented May 24, 2021

Flatten (reducing an animated GIF) should be allowed during encoding images in other formats.

Flatten (reducing an animated GIF) should be allowed during encoding
images in other formats.
@markevans
Copy link
Owner

hi - cheers for this - the only thing I'm concerned about is now there could be an ever-growing whitelist that I don't want to support, because encode is mainly just for switching to a different format (png -> jpg) and people can easily do their own custom processors.
What's flatten used for exactly and are there many other arguments that have a similar importance that could also be added to the whitelist (again, something I don't want to support) - thanks

@tvdeyen
Copy link
Author

tvdeyen commented May 24, 2021

We found a solution that works for us (AlchemyCMS/alchemy_cms#2106), so I thought it might be of interest for others.

But I absolutely understand that maintaining such list (can I suggest to rename it to Safelist for obvious reasons, btw.?) is not what you want to do.

Since mutating a constants seems a bit awkward, what about adding an extension point or configuration for adding arguments to that list?

@tvdeyen tvdeyen closed this Oct 28, 2023
@tvdeyen tvdeyen deleted the allow-flatten-with-encode branch October 28, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants