Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix strikethrough inside strong and em to follow gfm #3577

Merged
merged 2 commits into from
Jan 6, 2025
Merged

fix: fix strikethrough inside strong and em to follow gfm #3577

merged 2 commits into from
Jan 6, 2025

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Jan 5, 2025

Marked version: 15.0.5

Markdown flavor: GitHub Flavored Markdown

Description

Fix left flanking rules for GFM strikethrough

This is a follow-up to #3569 fixing some similar cases

Contributor

  • Test(s) exist to ensure functionality and minimize regression (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

@vercel Vercel
Copy link

vercel bot commented Jan 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marked-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2025 8:39am

Lmillan123
Lmillan123 approved these changes Jan 6, 2025
View reviewed changes
test/specs/new/strikethrough_in_em_strong.html
<p>b<strong><del>a</del></strong></p>

<p>b<strong><del>a</del></strong></p>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@

@UziTech UziTech merged commit 7712a53 into markedjs:master Jan 6, 2025
8 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 6, 2025
@semantic-release-bot
chore(release): 15.0.6 [skip ci]
5624378 
## [15.0.6](v15.0.5...v15.0.6) (2025-01-06)

### Bug Fixes

* fix strikethrough inside strong and em to follow gfm ([#3577](#3577)) ([7712a53](7712a53))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lmillan123 Lmillan123 Lmillan123 approved these changes

@styfle styfle styfle approved these changes

@calculuschild calculuschild Awaiting requested review from calculuschild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UziTech @styfle @Lmillan123