-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --test man documentation and changes argv parameters test/index.js #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
requested changes
Mar 10, 2019
I meant --minified and not --run. The loose parameter was a mistake. |
styfle
reviewed
Mar 10, 2019
UziTech
reviewed
Mar 11, 2019
UziTech
reviewed
Mar 11, 2019
UziTech
reviewed
Mar 11, 2019
To make the tests pass you will have to change - if (!specTests({stop: true})) {
+ if (!specTests(['', '', '--stop'])) { |
UziTech
reviewed
Mar 11, 2019
UziTech
reviewed
Mar 11, 2019
UziTech
approved these changes
Mar 12, 2019
styfle
approved these changes
Mar 12, 2019
This was referenced Mar 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version:
Markdown flavor: Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a
Description
marked/test/index.js
Line 554 in d96d1d3
Contributor
Committer
In most cases, this should be a different person than the contributor.