Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add docs for workers #1432

Merged
merged 12 commits into from
May 3, 2019
Merged

add docs for workers #1432

merged 12 commits into from
May 3, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 1, 2019 •
edited
Loading

Description

Add examples of how to run marked in a worker on node and in a browser.
https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers

fixes #1184

Contributor

  • no tests required for this PR.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

@UziTech UziTech added the category: docs Documentation changes label Mar 1, 2019
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
docs/USING_ADVANCED.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
docs/USING_ADVANCED.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
docs/USING_ADVANCED.md Outdated Show resolved Hide resolved
styfle
styfle reviewed Mar 2, 2019
View reviewed changes
docs/USING_ADVANCED.md Outdated Show resolved Hide resolved
@styfle
Copy link
Member

styfle commented Mar 2, 2019

There was one bug in the example that was mixing function keyword and arrow functions.

I think we should just use arrow functions for workers because its an advanced feature and so we can assume the reader understands ES6.

styfle
styfle approved these changes Mar 2, 2019
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@UziTech
Copy link
Member Author

UziTech commented Mar 2, 2019

Nice catch

@UziTech UziTech changed the title add docs for workers [WIP] add docs for workers Mar 7, 2019
@UziTech
Copy link
Member Author

UziTech commented Mar 7, 2019

wait to merge this until after worker_threads in node are stable

@UziTech UziTech mentioned this pull request Mar 11, 2019
Closed
@UziTech UziTech changed the title [WIP] add docs for workers add docs for workers Apr 26, 2019
@UziTech
Copy link
Member Author

UziTech commented Apr 26, 2019

I added notes about Worker Threads being experimental and Web Workers sending objects on postMessage instead of just the string.

https://docs-4nj255ohp.now.sh/#/USING_ADVANCED.md#workers

I think this should be good to merge.

styfle
styfle reviewed Apr 26, 2019
View reviewed changes
docs/USING_ADVANCED.md Outdated Show resolved Hide resolved
@UziTech UziTech requested review from davisjam and joshbruce May 3, 2019 18:08
@tdsnyk tdsnyk mentioned this pull request Oct 28, 2024
Open
@sri-sankari sri-sankari mentioned this pull request Oct 28, 2024
Open
@mohankumar931 mohankumar931 mentioned this pull request Oct 28, 2024
Open
@arunnsm arunnsm mentioned this pull request Oct 29, 2024
Open
@sound25 sound25 mentioned this pull request Oct 29, 2024
Open
@Latha-lgtm Latha-lgtm mentioned this pull request Oct 29, 2024
Open
@GOWTHAMAKURINJIVEANDAN GOWTHAMAKURINJIVEANDAN mentioned this pull request Oct 29, 2024
Open
@Dejah2024 Dejah2024 mentioned this pull request Oct 30, 2024
Open
@ThiruVaithiya ThiruVaithiya mentioned this pull request Oct 30, 2024
Open
@Upender5119 Upender5119 mentioned this pull request Oct 30, 2024
Open
@Suriya0802 Suriya0802 mentioned this pull request Oct 30, 2024
Open
@Shriv12 Shriv12 mentioned this pull request Oct 30, 2024
Open
@Magali0007 Magali0007 mentioned this pull request Oct 31, 2024
Open
@sureshrtech1 sureshrtech1 mentioned this pull request Oct 31, 2024
Open
@Praganya03 Praganya03 mentioned this pull request Oct 31, 2024
Open
@Ganesh13349 Ganesh13349 mentioned this pull request Oct 31, 2024
Open
@robertnorrie robertnorrie mentioned this pull request Oct 31, 2024
Open
@sinnakkrishnan sinnakkrishnan mentioned this pull request Nov 1, 2024
Open
@Vijay-2302 Vijay-2302 mentioned this pull request Nov 1, 2024
Open
@krithika-manohar krithika-manohar mentioned this pull request Nov 1, 2024
Open
@SAGAYANELSON55 SAGAYANELSON55 mentioned this pull request Nov 1, 2024
Open
@swathi-ra swathi-ra mentioned this pull request Nov 2, 2024
Open
@austinskou austinskou mentioned this pull request Nov 3, 2024
Open
@BD-HUGO BD-HUGO mentioned this pull request Nov 3, 2024
Open
@danielsb74 danielsb74 mentioned this pull request Nov 5, 2024
Open
@selvaganesh26 selvaganesh26 mentioned this pull request Nov 5, 2024
Open
@merkeldev merkeldev mentioned this pull request Nov 5, 2024
Open
@joedean-git joedean-git mentioned this pull request Nov 9, 2024
Open
@MimiDas-Snyk MimiDas-Snyk mentioned this pull request Nov 10, 2024
Open
@BenDrKo BenDrKo mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbruce joshbruce joshbruce approved these changes

@styfle styfle styfle approved these changes

@davisjam davisjam Awaiting requested review from davisjam

Assignees
No one assigned
Labels
category: docs Documentation changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: Markdown, storage and security
3 participants
@UziTech @styfle @joshbruce