-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: finish fixing unsafe heading regex #1226
Closed
Closed
Commits on Apr 26, 2018
-
security: finish fixing unsafe heading regex
Apply similar patch to a similar heading regex. Follow-on to f052a2c. Test: Add a test case to demonstrate the slower blow-up.
Configuration menu - View commit details
-
Copy full SHA for 0e07a9f - Browse repository at this point
Copy the full SHA 0e07a9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 990b452 - Browse repository at this point
Copy the full SHA 990b452View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5736014 - Browse repository at this point
Copy the full SHA 5736014View commit details -
Configuration menu - View commit details
-
Copy full SHA for 943d995 - Browse repository at this point
Copy the full SHA 943d995View commit details -
security: replace unsafe /X+$/ idiom with rtrim
Problem: replace(/X+$/, '') is vulnerable to REDOS Solution: Replace all instances I could find with a custom rtrim
Configuration menu - View commit details
-
Copy full SHA for 0cfe39e - Browse repository at this point
Copy the full SHA 0cfe39eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29be5f5 - Browse repository at this point
Copy the full SHA 29be5f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d5cfc7 - Browse repository at this point
Copy the full SHA 4d5cfc7View commit details
Commits on Apr 27, 2018
-
remove leading whitespace in paragraphs
Spec: No leading whitespace within a paragraph Fix: I strip leading whitespace on each line while rendering paragraphs Unanticipated problem: Causes the (previously failing but hidden) CommonMark 318 to fail. I added that to the list of expected-to-fail tests. This commit addresses a failing header test case noted in 943d995 whose root cause was paragraph rendering not up to spec.
Configuration menu - View commit details
-
Copy full SHA for dd26af8 - Browse repository at this point
Copy the full SHA dd26af8View commit details
Commits on Apr 28, 2018
-
WIP: safen the text regex via linear-time scans
Sketch implementing text regex as a linear-time RegExp imitator. - A few nits here and there - I haven't tested all of the offsetOfX routines, so 'npm run test' hangs on some bug
Configuration menu - View commit details
-
Copy full SHA for 24d4a5e - Browse repository at this point
Copy the full SHA 24d4a5eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.