Implemented Matter temperature measurement accessory. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaj-nordic
commented
Nov 2, 2022
markaj-nordic
commented
Nov 2, 2022
src/app_task.cpp
Outdated
| static constexpr int16_t kTemperatureMeasurementAttributeInvalidValue = 0x8000; | ||
| static constexpr uint8_t kTemperatureMeasurementEndpointId = 1; | ||
|
|
||
| struct sensor_value sTemperature; |
There was a problem hiding this comment.
struct not needed. Neither s prefix is.
ArekBalysNordic
approved these changes
Nov 2, 2022
Signed-off-by: Marcin Kajor <[email protected]>
markaj-nordic
force-pushed
the
temperature_sensor
branch
from
bacb1c1 to
850710b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marcin Kajor [email protected]
chip-tool commands for testing (Button4 starts the measurements):
./chip-tool interactive startpairing ble-thread 1 hex:<dataset> 20202021 3840temperaturemeasurement read measured-value 1 1identify identify 10 1 1temperaturemeasurement subscribe measured-value 1 1 1 1