Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat(analytics): request and store consent #151

Merged
merged 14 commits into from
Sep 23, 2024

Conversation

markafitzgerald1
Copy link
Owner

@markafitzgerald1 markafitzgerald1 commented Aug 30, 2024

Added UI to request and store user consent to the use of (Google) Analytics.

TODO

  • Add Privacy Policy to main app UI in this same PR... including screenshot e2e test to ensure no styling regressions.
  • Add actual use of Google Analytics in at least production - plus optionally to local development - to this same PR... without breaking local development (i.e. GA does not need to be on or enabled for the app to work).

@markafitzgerald1 markafitzgerald1 self-assigned this Aug 30, 2024
@markafitzgerald1 markafitzgerald1 added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 1, 2024
Pre-commit hook was allowing commits with non-final pre-commit hook
command failures to be committed.
Added Effective Date. Noted that analytics use is optional and
user-controlled. Added Use of Google Analytics, Consent and Local
Storage, Cookies, How We Use Your Information, Data Sharing and
Security sections. Made the Data Retention section more explicit.
Explained what 'local storage' is in terms suitable for non-technical
readers.
Replaced explicit statement of current Google Analytics default
retention period with a reference to Google Analytics.
Reduce scope of Cookies section to those used by Google Analytics as
only Google Analytics uses them in Cribbage Trainer.
Reduced scope of Data Sharing section to non-sensitive personal
information only and to Google Analytics only.
Improved wording of Contact Us section.
Merged similar cookies sections. Made minor wording improvements to How
We Use Your Information and Data Sharing sections.
Merged Consent and Cookies sections. Updated effective date.
Linked from analytics consent dialog.
@markafitzgerald1
Copy link
Owner Author

Actual use of Google Analytics suitable for use in production locally implemented with test automation. Manual e2e tests appear to work, but don't show events in Google Analytics. Still investigating, as apparently that should work.

@markafitzgerald1
Copy link
Owner Author

Local send of page loads does not seem to work. Consider instead pushing the local code adding the GA script + post-deploy to production testing via GA's "Test your website" button and some more manual testing against a non-local development (production) site with URL matching the one associated with the GA Stream.

Cookieless pings without consent, full measurement with consent.
@markafitzgerald1 markafitzgerald1 marked this pull request as ready for review September 22, 2024 20:58
@markafitzgerald1 markafitzgerald1 merged commit 881b558 into main Sep 23, 2024
5 checks passed
@markafitzgerald1 markafitzgerald1 deleted the 21-measure-production-app-usage branch September 23, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant