-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(analytics): request and store consent #151
Conversation
Pre-commit hook was allowing commits with non-final pre-commit hook command failures to be committed.
Added Effective Date. Noted that analytics use is optional and user-controlled. Added Use of Google Analytics, Consent and Local Storage, Cookies, How We Use Your Information, Data Sharing and Security sections. Made the Data Retention section more explicit.
Explained what 'local storage' is in terms suitable for non-technical readers.
Replaced explicit statement of current Google Analytics default retention period with a reference to Google Analytics.
Reduce scope of Cookies section to those used by Google Analytics as only Google Analytics uses them in Cribbage Trainer.
Reduced scope of Data Sharing section to non-sensitive personal information only and to Google Analytics only.
Improved wording of Contact Us section.
Merged similar cookies sections. Made minor wording improvements to How We Use Your Information and Data Sharing sections.
Merged Consent and Cookies sections. Updated effective date.
Linked from analytics consent dialog.
Actual use of Google Analytics suitable for use in production locally implemented with test automation. Manual e2e tests appear to work, but don't show events in Google Analytics. Still investigating, as apparently that should work. |
Local send of page loads does not seem to work. Consider instead pushing the local code adding the GA script + post-deploy to production testing via GA's "Test your website" button and some more manual testing against a non-local development (production) site with URL matching the one associated with the GA Stream. |
Cookieless pings without consent, full measurement with consent.
Added UI to request and store user consent to the use of (Google) Analytics.
TODO