Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Store Naming and Eject React #1

Merged
merged 11 commits into from
Oct 5, 2017

Conversation

sdzharkov
Copy link

@sdzharkov sdzharkov commented Oct 3, 2017

Completed in PR

  • Ejected create-react-app for access to babel, which allows us to use decorators.
    • Babel file was based upon current mobx documentation.
  • Updated naming convention of all stores. Each store's name should ideally have 'store' within it to draw less confusion when importing stores into components.
    • I updated the initialized item name and the class itself.
  • Added an index.js files for all stores, and imported the stores into App.js. Stores are passed into the Provider method of 'mobx-react'.
  • Added a build_scripts folder that will hold build, start, and test files.

Things to test

  • Ensure that the ejection from create-react-app will not obstruct our build process.
  • Check to see that the provider component has access to the stores. This can be easily done through react-devtools, by checking that the props contain an object of stores.

@mark-antony1 mark-antony1 merged commit 4878d48 into mark-antony1:master Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants