[documenttranslation] Add default values for parameter in convenienve…

… method
maririos · Mar 3, 2021 · 9f57aec · 9f57aec
1 parent 0052f64
commit 9f57aec
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 24 deletions.
diff --git a/sdk/documenttranslation/Azure.AI.DocumentTranslation/src/DocumentTranslationClient.cs b/sdk/documenttranslation/Azure.AI.DocumentTranslation/src/DocumentTranslationClient.cs
@@ -159,7 +159,7 @@ public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(Li
         /// <param name="options"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
-        public virtual DocumentTranslationOperation StartTranslation(Uri sourceUrl, Uri targetUrl, string targetLanguage, List<TranslationGlossary> glossaries, TranslationOperationOptions options, CancellationToken cancellationToken = default)
+        public virtual DocumentTranslationOperation StartTranslation(Uri sourceUrl, Uri targetUrl, string targetLanguage, List<TranslationGlossary> glossaries = default, TranslationOperationOptions options = default, CancellationToken cancellationToken = default)
         {
             var source = new SourceConfiguration(sourceUrl.AbsoluteUri)
             {
@@ -207,7 +207,7 @@ public virtual DocumentTranslationOperation StartTranslation(Uri sourceUrl, Uri
         /// <param name="options"></param>
         /// <param name="cancellationToken"></param>
         /// <returns></returns>
-        public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(Uri sourceUrl, Uri targetUrl, string targetLanguage, List<TranslationGlossary> glossaries, TranslationOperationOptions options, CancellationToken cancellationToken = default)
+        public virtual async Task<DocumentTranslationOperation> StartTranslationAsync(Uri sourceUrl, Uri targetUrl, string targetLanguage, List<TranslationGlossary> glossaries = default, TranslationOperationOptions options = default, CancellationToken cancellationToken = default)
         {
             var source = new SourceConfiguration(sourceUrl.AbsoluteUri)
             {

diff --git a/...cumenttranslation/Azure.AI.DocumentTranslation/tests/samples/Sample_TranslateOperation.cs b/...cumenttranslation/Azure.AI.DocumentTranslation/tests/samples/Sample_TranslateOperation.cs
@@ -24,17 +24,7 @@ public void TranslateOperation()
 
             var client = new DocumentTranslationClient(new Uri(endpoint), new AzureKeyCredential(apiKey));
 
-            var glossaries = new List<TranslationGlossary>()
-            {
-                new TranslationGlossary(glossaryUrl)
-            };
-
-            var options = new TranslationOperationOptions
-            {
-                StorageType = StorageType.Folder
-            };
-
-            DocumentTranslationOperation operation = client.StartTranslation(sourceUrl, targetUrl, "it", glossaries, options);
+            DocumentTranslationOperation operation = client.StartTranslation(sourceUrl, targetUrl, "it");
 
             TimeSpan pollingInterval = new TimeSpan(1000);
 

diff --git a/...ttranslation/Azure.AI.DocumentTranslation/tests/samples/Sample_TranslateOperationAsync.cs b/...ttranslation/Azure.AI.DocumentTranslation/tests/samples/Sample_TranslateOperationAsync.cs
@@ -24,17 +24,7 @@ public async Task TranslateOperationAsync()
 
             var client = new DocumentTranslationClient(new Uri(endpoint), new AzureKeyCredential(apiKey));
 
-            var glossaries = new List<TranslationGlossary>()
-            {
-                new TranslationGlossary(glossaryUrl)
-            };
-
-            var options = new TranslationOperationOptions
-            {
-                StorageType = StorageType.Folder
-            };
-
-            DocumentTranslationOperation operation = client.StartTranslation(sourceUrl, targetUrl, "it", glossaries, options);
+            DocumentTranslationOperation operation = client.StartTranslation(sourceUrl, targetUrl, "it");
 
             Response<AsyncPageable<DocumentStatusDetail>> operationResult = await operation.WaitForCompletionAsync();