-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request - Rendering Dockerfile #108
Comments
That's a really good idea. I think a good approach would be to "detach" the public IContainerImageService Build()
{
return _parent.Build();
} Where the To access the "public" using (var dockerfile = Fd.DockerFile(/*empty ctor - string only*/)) // ... What do you think about that? Cheers, |
It makes a perfect sense to me. |
This is to assist unittest and solves Issue #108.
FileBuilder now supports to do everything is it will for the ImageBuilder without the need to use the image builder. It is then possible to use command to build the dockerfile or other custom functionality.
[Fix] Liner ordering needs to be strict in FileBuilder. It also addresses Issue #108 where a Dockerfile can be produced as a string without ImageBuilder is involved to actually build it.
fixed - will be released in next release. |
Feature Proposal
Would be great to add a feature to render Dockerfile and docker-compose file.
Use-case
It provides generating and updating Dockerfiles using code. It helps to automate these tasks. Great for applying consistency to multiple project and services, e.g. microservices.
Implementation
Would be limited to FileBuilder with making the RenderDockerfile public.
Also, RenderDockerfileAsString() can be added to facilitate automated testing.
Actions
I am happy to raise the PR as soon as the maintainers have approved the proposal.
I couldn't find any documentation about contributing so I just raise it here
The text was updated successfully, but these errors were encountered: