Minor fix to registry #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved from #83 |
| @@ -33,7 +37,7 @@ _.extend(TypeRegistry.prototype, { | |||
|
|
|||
| // Remove an item from a given type registration | |||
| unregister: function(type) { | |||
| if (this.registeredTypes[type]) { | |||
| if (_.has(this.registeredTypes,type)) { | |||
There was a problem hiding this comment.
Please pop in a space for formatting:
if (_.has(this.registeredTypes, type)) {
There was a problem hiding this comment.
oops, forgot to reformat document
There was a problem hiding this comment.
no probs, once #88 lands, this kind of stuff will be picked up on grunt test
|
Great stuff @BorisKozo. Could you please squash this down to 1 commit? |
Changed hasOwnProperty to _.has Fixed issue where you could not register or unregister falsy items
BorisKozo
force-pushed
the
minor-fix-to-registry
branch
from
dbb9baf to
b1ae326
Compare
|
Special Sauce. Thanks @BorisKozo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #77
Added some unit tests for the type registry
Fixed 2 typos in existing unit tests that were found due to this change