Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD wrapper, remove separate AMD version #39

Merged
merged 1 commit into from
Apr 25, 2014

Conversation

jamiebuilds
Copy link
Member

Related PRs in Backbone.Marionette and Backbone.Wreqr.


Changes:

  • Remove AMD version
  • Add UMD wrapper
    • update Gruntfile
    • update component.json
    • update package.json

UMD Details

  • AMD
    • return Backbone.ChildViewContainer
    • Backbone.ChildViewContainer is defined
  • CommonJS
    • module.exports = Backbone.ChildViewContainer
    • Backbone.ChildViewContainer is defined
  • Browser
    • Backbone.ChildViewContainer is defined

Let me know if this pull request needs anything else. Thanks!

@ahumphreys87
Copy link
Member

lgtm 👍

@jamiebuilds
Copy link
Member Author

Rebased

samccone added a commit that referenced this pull request Apr 25, 2014
Add UMD wrapper, remove separate AMD version
@samccone samccone merged commit 9f1ada9 into marionettejs:master Apr 25, 2014
@jamiebuilds jamiebuilds deleted the umd branch April 25, 2014 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants