resolving merge conflicts #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs were meant to include details of the config fields and the module API, but at some point, those quit working. I suspect it was due to an update in sphinx or its modules, but I am not sure, as I use auto-updated packaged versions from Debian. The current versions of autoclass/automodule require default options to be specified differently. This fixes those default options. Also, in our docs post-processing callback, a change was needed in how we get the full names of the members we are documenting. Change-Id: I50b6af7ebd2c23f26c55abbd97e3336d8665f24f
The old theme did not put enough space between members. The new theme does this better, but required some extra configuration for the table of contents in the sidebar. Change-Id: I9fc51471551a8176d2279add8087a9ca1909be07
Every type defined in these docs has a hash that can be linked to to see its fields or enum values. But Sphinx isn't linking to them automatically. This may be caused by a missing Sphinx plugin, but since we heavily post-process the generated type info for our config docs (see docs/source/conf.py), it is easiest to add these links in JavaScript after the docs load. Now where the docs say something like "inputs: list of Input", the word "Input" is a link to the definition of that type. Change-Id: I148fa76de01baa53d235944d66c1fbcf74cd5ce6
…ject#86) This PR removes the "hw:" enum values, making the enum only for the base codecs. If a codec is prefixed with "hw:", it will be caught in the _missing_ hook. We will try to know if it can be one of the base variants or not. If it is a base variant, we will set the _hw_acc to True for this codec. If not, we will fall back to super()._missing_ to have a proper error message.
## Feature - Allow users to specify a HTTP url as an output - Segments and manifests will be uploaded to the specified url via HTTP PUT - Urls ending with a '/' will have the slash removed to prevent issues with Google Cloud ## Testing - Added unit tests to check for config compatibility errors, such as specifying an HTTP url output with a "multi_period_input" and with "segment_per_file" set to false ## Shortcomings - The multi period input list feature is currently structured to use the local file system and does not easily support HTTP uploads. This must be addressed as the multi period input feature continues to evolve - The HTTP upload feature does not make sense if used with a cloud url, and although there is an error check for this, there is no unit test. The cloud url unit test would have required a mock bucket to pass the cloud url validity checks. Because of the work involved in writing a mock bucket and [the future (and hopefully soon) removal of the CloudNode](CaitlinOCallaghan#2 (comment)), it was decided that forgoing this particular unit test was okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.