Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang: Disable unused-function warnings for 3rd-party NCCL library #599

Merged
merged 2 commits into from
Feb 15, 2020
Merged

clang: Disable unused-function warnings for 3rd-party NCCL library #599

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a567c
clang: Disable unused-function warnings for 3rd-party NCCL library
kpu Feb 11, 2020
0873311
Gate warning on clang
kpu Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/3rd_party/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ if(CUDA_FOUND)
if(COMPILE_CUDA_SM70)
set(GENCODE "${GENCODE} -gencode=arch=compute_70,code=sm_70")
endif(COMPILE_CUDA_SM70)
# clang generates a lot of unused function warnings for NCCL
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
set(NCCL_CXXFLAGS "-Wno-unused-function")
else()
set(NCCL_CXXFLAGS "")
endif()

# install nccl in ${CMAKE_BINARY_DIR}/local similar to /usr/local linux installation
ExternalProject_Add(nccl_install
Expand All @@ -95,7 +101,7 @@ if(CUDA_FOUND)
BUILD_COMMAND
$(MAKE) -f ${CMAKE_CURRENT_SOURCE_DIR}/nccl/Makefile src.build
BUILDDIR=${CMAKE_BINARY_DIR}/local CUDA_HOME=${CUDA_TOOLKIT_ROOT_DIR}
CUDA8_GENCODE=${GENCODE} CXX=${CMAKE_CXX_COMPILER}
CUDA8_GENCODE=${GENCODE} CXX=${CMAKE_CXX_COMPILER} CXXFLAGS=${NCCL_CXXFLAGS}
INSTALL_COMMAND "")

set_target_properties(nccl PROPERTIES IMPORTED_LOCATION ${CMAKE_BINARY_DIR}/local/lib/libnccl_static.a)
Expand Down