Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cipher on android #399

Merged
merged 8 commits into from
Aug 11, 2024
Merged

fix: cipher on android #399

merged 8 commits into from
Aug 11, 2024

Conversation

boorad
Copy link
Collaborator

@boorad boorad commented Jul 30, 2024

tries to help #398 and #403 by moving react and react-native back into devDependencies (and adding to peerDependencies).

new test still failing, will fix in future, maybe public key is the problem?

begin conversion from yarn -> bun (but not GHA yet)

bump minSDKVersion for Android to something almost in this decade.

@boorad boorad self-assigned this Jul 30, 2024
@boorad boorad force-pushed the fix/398-cipher-android branch from ede35fd to 41d5da9 Compare July 30, 2024 19:32
@boorad boorad merged commit f8161c0 into margelo:main Aug 11, 2024
6 checks passed
@boorad boorad deleted the fix/398-cipher-android branch August 11, 2024 02:05
@wh201906
Copy link

wh201906 commented Aug 16, 2024

Hi @boorad. Is there any specific reason for bumping the minSDKVersion to 28? Even the upcoming React Native 0.76 supports API 24
https://reactnative.dev/blog/2024/08/12/release-0.75#last-version-supporting-minsdk-23-and-miniosversion-134
I think bumping the minSDKVersion to 28 is very aggressive because it affects around 7.8% Android Devices, according to the Play Store statistics from May 2024 (from API 24 to API 28)
react-native-community/discussions-and-proposals#802
Would you consider decreasing the minSDKVersion to 24?

@boorad
Copy link
Collaborator Author

boorad commented Aug 17, 2024

Yes, I was too aggressive. I'll move it back.

@boorad boorad mentioned this pull request Aug 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants