Clean-up

mareklibra · Feb 28, 2023 · ab60712 · ab60712
1 parent 4a1140b
commit ab60712
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/plugins/orion/src/components/PluginRouter.tsx b/plugins/orion/src/components/PluginRouter.tsx
@@ -16,7 +16,10 @@ export const PluginRouter = () => (
     <Route path="/notification" element={<Notification />} />
     <Route path="/training" element={<Training />} />
     <Route path="/metrics" element={<Metrics />} />
-    <Route path="/onboarding/:projectId/:workflowId/new/" element={<Onboarding isNew />} />
+    <Route
+      path="/onboarding/:projectId/:workflowId/new/"
+      element={<Onboarding isNew />}
+    />
     <Route
       path="/onboarding/:executionId/workflow-detail"
       element={<WorkFlowDetail isNew />}

diff --git a/plugins/orion/src/components/workflow/Onboarding.tsx b/plugins/orion/src/components/workflow/Onboarding.tsx
@@ -18,8 +18,6 @@ import {
 } from '../../context/WorkflowParametersContext';
 import { mockAndromedaWorkflowDefinition } from './mockData';
 
-// TODO: use WorkflowStepper component after http://161.156.17.167:8080/swagger-ui/index.html#/Workflow/execute
-
 const getAllFlattenedParameters = (
   allWorkflowDefinitions: WorkflowDefinitionType[],
   workflowDefinition: WorkflowDefinitionType,
@@ -98,7 +96,6 @@ export const OnboardingImpl: React.FC<OnboardingProps> = ({ isNew }) => {
   const [workflowParameters, setWorkflowParameters] = React.useState<
     WorkFlowTaskParameterType[]
   >([]); // parameters from whole chain of tasks - nextWorkflow
-  // TODO: provide inra for storing dynamic parameters
 
   React.useEffect(() => {
     if (!workflowId) {
@@ -145,7 +142,7 @@ export const OnboardingImpl: React.FC<OnboardingProps> = ({ isNew }) => {
 
   const onStart = async () => {
     const body: WorkflowType = {
-      projectId,
+      projectId: projectId || 'missing',
       workFlowName: workflow?.name || 'missing',
       workFlowTasks:
         workflow?.tasks.map(task => {
@@ -178,6 +175,7 @@ export const OnboardingImpl: React.FC<OnboardingProps> = ({ isNew }) => {
       });
     } catch (e) {
       setError('Failed to start workflow');
+      // eslint-disable-next-line no-console
       console.error('Failed to start workflow: ', e);
     }
   };

diff --git a/plugins/orion/src/components/workflow/Workflow.tsx b/plugins/orion/src/components/workflow/Workflow.tsx
@@ -20,15 +20,19 @@ import {
 import { useCommonStyles } from '../../styles';
 import { ParodosPage } from '../ParodosPage';
 import { useBackendUrl } from '../api';
-import { AssessmentStatusType, ProjectType, WorkflowDefinitionType } from '../types';
+import {
+  AssessmentStatusType,
+  ProjectType,
+  WorkflowDefinitionType,
+} from '../types';
 import { mockAndromedaWorkflowDefinition } from './mockData';
 
 const useStyles = makeStyles({
   applicationHeader: {
     background: 'gray',
   },
   applicationCard: {
-    'height': '15rem',
+    height: '15rem',
     width: '17rem',
   },
 });
@@ -72,8 +76,8 @@ export const Workflow = () => {
             }),
           },
         );
-        const project = (await response.json()) as ProjectType;
-        setProject(project);
+        const prj = (await response.json()) as ProjectType;
+        setProject(prj);
 
         setAssessmentStatus('complete');
 
@@ -105,7 +109,10 @@ export const Workflow = () => {
         );
 
         // mock
-        filteredWorkflowDefinitions = [mockAndromedaWorkflowDefinition, ...filteredWorkflowDefinitions];
+        filteredWorkflowDefinitions = [
+          mockAndromedaWorkflowDefinition,
+          ...filteredWorkflowDefinitions,
+        ];
 
         setWorkflowDefinitions(filteredWorkflowDefinitions);
       } catch (e) {
@@ -115,7 +122,7 @@ export const Workflow = () => {
       }
     };
     doItAsync();
-  }, []);
+  }, [backendUrl]);
 
   return (
     <ParodosPage>