Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated default options #1118

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Updated default options #1118

merged 3 commits into from
Oct 6, 2024

Conversation

marekdedic
Copy link
Owner

@marekdedic marekdedic commented Oct 6, 2024

  • Removed the quitOnEscKey option
  • Changed default options

Closes #942

@marekdedic marekdedic marked this pull request as draft October 6, 2024 18:24
Copy link

relativeci bot commented Oct 6, 2024

imagelightbox-jquery

#184 Bundle Size — 11.79KiB (-0.4%).

e6b9195(current) vs f42e1eb master#172(baseline)

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
#184
     Baseline
#172
Improvement  Initial JS 11.79KiB(-0.4%) 11.84KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 27 27
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#184
     Baseline
#172
Improvement  JS 11.79KiB (-0.4%) 11.84KiB

Bundle analysis reportBranch default-option-changeProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link

relativeci bot commented Oct 6, 2024

imagelightbox-native

#808 Bundle Size — 11.14KiB (-0.42%).

e6b9195(current) vs f42e1eb master#796(baseline)

Bundle metrics  Change 1 change Improvement 1 improvement
                 Current
#808
     Baseline
#796
Improvement  Initial JS 11.14KiB(-0.42%) 11.19KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 100% 100%
No change  Chunks 1 1
No change  Assets 1 1
No change  Modules 26 26
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#808
     Baseline
#796
Improvement  JS 11.14KiB (-0.42%) 11.19KiB

Bundle analysis reportBranch default-option-changeProject dashboard


Generated by RelativeCIDocumentationReport issue

@marekdedic marekdedic force-pushed the default-option-change branch 4 times, most recently from bae6e9c to 226e02c Compare October 6, 2024 23:02
@marekdedic marekdedic force-pushed the default-option-change branch from 226e02c to e6b9195 Compare October 6, 2024 23:18
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11205989515

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 87.277%

Files with Coverage Reduction New Missed Lines %
src/lib/history.ts 1 91.89%
Totals Coverage Status
Change from base Build 11203153612: 0.4%
Covered Lines: 391
Relevant Lines: 448

💛 - Coveralls

@marekdedic marekdedic marked this pull request as ready for review October 6, 2024 23:25
@marekdedic marekdedic merged commit 7a5522f into master Oct 6, 2024
15 checks passed
@marekdedic marekdedic deleted the default-option-change branch October 6, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default values for options
2 participants