Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the Installation with CocoaPods #268

Merged
merged 2 commits into from
Nov 8, 2017

Conversation

liuwin7
Copy link
Contributor

@liuwin7 liuwin7 commented Feb 16, 2017

The 'Usage' describes the latest version 6.0.2 and the 'Installation with CocoaPods' installs the version 5.2.0. So, if someone follows the tutor, the Objc will not connect with javascript. The reason is here #266 (comment) .

Before your create your PR:

Please add tests for any new or changed functionality!

I have not modified any functionalities for your repo. What I have done is to modifying some infos in README.md.

Thanks.

The 'Usage' describes the latest version 6.0.2 and the 'Installation with CocoaPods' installs the version 5.2.0. So, if someone follows the tutor,  the Objc will not connect with javascript. The reason is here marcuswestin#266 (comment) .
@lokimeyburg
Copy link
Collaborator

Cool! I'll take a look at this and report back. Thanks for spotting that.

@marcuswestin
Copy link
Owner

Thank you!

@marcuswestin marcuswestin merged commit 4a6f596 into marcuswestin:master Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants