Test run on GitHub Actions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ap.png or -elevations.png
|
Amazing, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI
This doesn't test correctness, but does test the program can run without erros, and does so on matrix of Windows, macOS and Ubuntu and on Python versions 3.7-3.10.
I added the GPX files from https://github.com/marcusvolz/strava/tree/master/inst/gpx/cycling to
tests/gpxhere as input.Here's a sample run: https://github.com/hugovk/strava_py/actions/runs/1808323998
After running, it also uploads the output files as an artifact, you click "images" to download a zip and check how they look.
(Note: there's a single file even though there's 12 jobs in the matrix. I think each one overwrites previous ones. We could probably set it to upload images from each job, but I think this is fine for now.)
Also
Rename src package directory to
stravavisReview comments from added plot_map #2