Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyclemeter Support #37

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

wiredfool
Copy link

Cyclemeter stores similar data to Strava -- at least, you can download a sqlite db of all the activity data stored in your personal iCloud instance.

This is a draft PR to provide basic support to pull data from that sqlitedb and run the same visualizations as from Strava. Not sure if this makes sense as an addition to this project or a fork. Your call on that one.

Some caveats:

  • Tests aren't implemented, as I'd have to anonymize a cyclemeter db to do that.
  • It yields gigantic images so perhaps it would make sense on some of these to push down the year selectors to the mapping functions. Thousands of workouts are rather slow.

@wiredfool wiredfool marked this pull request as draft August 26, 2023 11:44
@marcusvolz
Copy link
Owner

Thank you @wiredfool - this looks good to me (adds support for Cyclemeter db files). I've not used Cyclemeter before, so I don't have any files to test. @hugovk are you happy with the changes or do you have any thoughts? Please feel free to merge if you are happy.

@hugovk
Copy link
Collaborator

hugovk commented Aug 28, 2023

Hi Eric!

I'm fine with the changes (once the linter is appeased), it would be nice to add a test database to make sure the code runs properly.

Can we create one with the GPX files in https://github.com/marcusvolz/strava_py/tree/main/tests/gpx? We don't have unit tests (yet?) but there's some sanity test runs in tox.ini.

Linter:

$ pip install pre-commit; pre-commit run --all-files

$ # or

$ pip install black isort flake8; black .; isort .; flake8

@hugovk hugovk added the enhancement New feature or request label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants