Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to marcusvolz/strava#5.
Here's the same GPX using
main
:Like https://stackoverflow.com/a/14457180/724176, rather than using latitude and longitude values, this uses a Mercator projection calculation to come up with x and y values instead.
Dummy, unit map width and height values are used, as we don't know and don't need to know the final size as matplotlib will take care of that.
And with this PR:
Measuring performance:
With
main
, on 2,946 GPX files (but commenting out some bits ofcli.py
to only run "Processing data..." and "Plotting map..."), it takes 11m45s on a Mac M1 16GB.With the PR it takes a comparable 11m43s, which is really good because the transform is done by Pandas so presumably in C.