Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dumbbell #13

Merged
merged 5 commits into from
Feb 13, 2022
Merged

Dumbbell #13

merged 5 commits into from
Feb 13, 2022

Conversation

marcusvolz
Copy link
Owner

Adding a dumbbell plot which shows activities as line segments showing start->end times by time of day and day of year.

It includes an option for the user to specify a local timezone, which is a temporary solution. It would be better for all time-related pre-processing to be done in process_data as timezone specifications also impact the calendar plot and future time-related plots.

Ideally the timezone could be inferred from lat / lon in the GPX / FIT files on a point-by-point basis (to address the unlikely edge case where the timezone changes during an activity), perhaps using https://pypi.org/project/tzwhere/, then joined to activities using the "Filename" column in activities.csv.

Other issues:

  • Activities that cover multiple days (e.g. 10pm Day 1 to 3am Day 2) are not being handled correctly - need to be split up into separate line segments.
  • There is a daylight savings time issue which is yet to be resolved - temp solution is to use .dt.tz_localize(tz='UTC', nonexistent='NaT', ambiguous='NaT') which can result in data loss.

@marcusvolz marcusvolz requested a review from hugovk February 12, 2022 13:18
src/stravavis/cli.py Outdated Show resolved Hide resolved
Co-authored-by: Hugo van Kemenade <[email protected]>
@marcusvolz marcusvolz merged commit 015e329 into main Feb 13, 2022
@marcusvolz marcusvolz deleted the dumbbell branch February 13, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants