Bug: cannot analyse value if is interpolated

[Gert-JanPeeters]

I ran into the same issue as described in #21 and #28.

This also supports blade and php, next to erb.

ToDo:

• data-controller
• data-[identifier]-[value]-value
• data-[identifier]-target
• data-action
• cleanup

[marcoroth]

Thanks for working on this @Gert-JanPeeters! I think this resolves the issues at hand.

Though, there are some cases we should think about. I'm not sure if this should also happen in this PR, but here it goes:

• Currently this only fixes it for data-[identifier]-[value]-value attributes, but technically this could be the case for any Stimulus-attribute.

  So maybe it would make sense to extract this logic out of the validateDataValueAttribute() function and apply it for all the data attribute validation methods in the diagnostics.ts file.

• With the current approach we skip the analysis of the whole attribute if it finds any kind of interpolation, but I assume there are also cases like this:

 <div data-controller="some-controller <%= "some-dynamic-controller" %>">
   <!-- ... -->
 </div>

I guess we could ignore this for now and open another issue for it. But I think we should still try to process the analysis for some-controller in this case.

What do you think?

[Gert-JanPeeters]

I think we should indeed tackle the issues you raised. No point in postponing it to the future.

Let me work on this a bit more so we also resolve the other issues that you raised 👍🏼

[marcoroth]

This looks great to me @Gert-JanPeeters, thanks! 🙌🏼

We can merge it if you could resolve the merge conflicts

[Gert-JanPeeters]

Ready to be merged 🚀

[marcoroth]

Thank you so much @Gert-JanPeeters! 🙌🏼