Support for multiple controller root folders #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
added
enhancement
marcoroth
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for handling multiple controller root folders. This is useful when a project has more than one folder where it defines Stimulus controllers.
Previously any controller which wasn't located in
app/javascript/controllers/wouldn't be provided with the right identifier. For example a controller inapp/packs/controllers/test_controller.jswould have been provided asapp--packs--controllers--testwhich obviously isn't right. This is now fixed and will be correctly provided astest.The
stimulus-parsernow automatically detects these root folders and doesn't rely on the hard-codedapp/javascript/controllers/folder.Additionally the
stimulus.controller.createQuick-Fix action now also accounts for multiple root folders. If the project has more than one root it will prompt you to choose a root folder location:This might fix #26.