Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diagnostics for Stimulus Value types #212

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Add diagnostics for Stimulus Value types #212

merged 1 commit into from
Mar 5, 2024

Conversation

marcoroth
Copy link
Owner

@marcoroth marcoroth commented Mar 5, 2024 •
edited
Loading

This pull requests adds the stimulus.controller.value_definition.unknown_type diagnostic. We show this diagnostic when the given type for a Stimulus value is none of the known types (Array, Boolean, Number, Object or String).

CleanShot 2024-03-05 at 04 30 32

Resolves #168

@marcoroth marcoroth added the diagnostic Feature that implements a `textDocument/diagnostic` request. label Mar 5, 2024
This was referenced Mar 5, 2024
Closed
Open
@marcoroth marcoroth merged commit 54be32f into main Mar 5, 2024
4 checks passed
@marcoroth marcoroth deleted the validate-stimulus-value-defintion-type branch March 5, 2024 03:53
@marcoroth marcoroth mentioned this pull request Mar 5, 2024
Closed
@marcoroth marcoroth mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
diagnostic Feature that implements a `textDocument/diagnostic` request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnostic: Warn if invalid Stimulus Values Type is used
1 participant
@marcoroth