Print position parameter as 'pos'

[adamltyson]

Hi @marcomusy. I noticed that when printing the camera position, it returns position when the docs state it should be pos.

This PR changes this from position to pos to match the docs and helps us stay consistent in brainrender.

I think this is a simple change, but let me know if I've missed anything.

[coderabbitai]

Walkthrough

The _default_keypress function in the vedo/plotter.py file was updated to modify the key name from position to pos in the printed template Python code for camera positioning. This change ensures consistency and potentially simplifies the code.

Changes

File	Change Summary
vedo/plotter.py	Updated _default_keypress function to change the key position to pos in the printed template Python code for camera positioning.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (4)

vedo/plotter.py (4)

Line range hint 3419-3419: Avoid using bare except.

- except:
+ except Exception as e:
+     vedo.logger.error("Error encountered: " + str(e))

---

Line range hint 3669-3669: Avoid using bare except.

- except:
+ except Exception as e:
+     vedo.logger.error("Error encountered: " + str(e))

---

Line range hint 4399-4399: Avoid using bare except.

- except:
+ except Exception as e:
+     vedo.logger.error("Error encountered: " + str(e))

---

Line range hint 4444-4444: Avoid using bare except.

- except:
+ except Exception as e:
+     vedo.logger.error("Error encountered: " + str(e))

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between afdade4 and f76ebbe.

Files selected for processing (1)

• vedo/plotter.py (1 hunks)

Additional context used

Ruff

vedo/plotter.py

559-559: Ambiguous variable name: l (E741)

---

3419-3419: Do not use bare except (E722)

---

3669-3669: Do not use bare except (E722)

---

4399-4399: Do not use bare except (E722)

---

4444-4444: Do not use bare except (E722)

[coderabbitai]

Update camera position print format to ensure high precision.

- vedo.printc("    pos=" + utils.precision(cam.GetPosition(), 6) + ",", c="y")
+ vedo.printc("    pos=" + utils.precision(cam.GetPosition(), 7) + ",", c="y")

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	vedo.printc(" pos=" + utils.precision(cam.GetPosition(), 6) + ",", c="y")
	vedo.printc(" pos=" + utils.precision(cam.GetPosition(), 7) + ",", c="y")