Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting of limit on object creation #2

Closed
therebelrobot opened this issue Aug 31, 2015 · 2 comments
Closed

Allow for setting of limit on object creation #2

therebelrobot opened this issue Aug 31, 2015 · 2 comments

Comments

@therebelrobot
Copy link
Collaborator

Hi @marcojetson! Have to say, I love how simple (and working) your lib is. I'm planning on submitting a PR for this and a few other things I was looking at. Also thinking about a programmatic way to update the candidates (I'll open a separate issue for that though).

What are your thoughts on also having a browserify version for publishing on NPM? I'd be happy to get a PR rolling for that too.

Thanks again for the great lib! Looking at its inclusion into a work project, I'll let you know when it's live for you to see.

@therebelrobot therebelrobot changed the title Allow for setting of limit on field creation Allow for setting of limit on object creation Aug 31, 2015
@marcojetson
Copy link
Owner

Hey @therebelrobot, thank you!

I like the idea of being able to setup the input in a single line but I'm afraid of having too many positional parameters.
What do you think about providing a settings parameter that allows to override different options using names? The candidates can be moved to that object too.

Having a browserify version is a great idea :)

@therebelrobot
Copy link
Collaborator Author

Yeah, normally for overriding options I just end up supplying an opts object parameter, and if the overriding item is in there it is used. I can work up an example and show you real quick.

I'll get another issue open for browserify then :) I've published a few of those in the past, happy to get it rolling for you.

therebelrobot added a commit to therebelrobot/type-ahead.js that referenced this issue Aug 31, 2015
@therebelrobot therebelrobot mentioned this issue Aug 31, 2015
therebelrobot added a commit to therebelrobot/type-ahead.js that referenced this issue Aug 31, 2015
therebelrobot added a commit to therebelrobot/type-ahead.js that referenced this issue Aug 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants