Skip to content

Commit

Permalink
Bug 1855747: Raise fractional digits limit to 100. r=dminor
Browse files Browse the repository at this point in the history
Implements the changes from <tc39/ecma402#786>.

Drive-by change:
Enable another test which no longer fails.

Differential Revision: https://phabricator.services.mozilla.com/D189541

UltraBlame original commit: 50ef49e1e6cc9c7c73f8aec7ee3375a5b0abf83b
  • Loading branch information
marco-c committed Nov 8, 2023
1 parent 4357af4 commit 1cb8981
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 120 deletions.
23 changes: 0 additions & 23 deletions intl/components/src/NumberFormatterSkeleton.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2277,29 +2277,6 @@ mxfd
to
100
.
(
20
is
the
current
limit
for
ECMA
-
402
but
there
are
/
/
plans
to
change
it
to
100
.
)
constexpr
size_t
maxFracDigits
Expand Down
8 changes: 4 additions & 4 deletions js/src/builtin/intl/NumberFormat.js
Original file line number Diff line number Diff line change
Expand Up @@ -1688,7 +1688,7 @@ DefaultNumberOption
(
mnfd
0
20
100
undefined
)
;
Expand All @@ -1707,7 +1707,7 @@ DefaultNumberOption
(
mxfd
0
20
100
undefined
)
;
Expand Down Expand Up @@ -3342,7 +3342,7 @@ minimumFractionDigits
integer
[
0
20
100
]
/
/
Expand All @@ -3351,7 +3351,7 @@ maximumFractionDigits
integer
[
0
20
100
]
/
/
Expand Down
4 changes: 2 additions & 2 deletions js/src/builtin/intl/PluralRules.js
Original file line number Diff line number Diff line change
Expand Up @@ -851,7 +851,7 @@ minimumFractionDigits
integer
[
0
20
100
]
/
/
Expand All @@ -860,7 +860,7 @@ maximumFractionDigits
integer
[
0
20
100
]
/
/
Expand Down
91 changes: 0 additions & 91 deletions js/src/tests/jstests.list
Original file line number Diff line number Diff line change
Expand Up @@ -16025,97 +16025,6 @@ catch
.
js
#
https
:
/
/
github
.
com
/
tc39
/
proposal
-
intl
-
numberformat
-
v3
/
pull
/
107
skip
script
test262
/
intl402
/
NumberFormat
/
test
-
option
-
useGrouping
.
js
#
https
:
/
/
github
.
com
/
tc39
/
test262
/
pull
/
3875
skip
script
test262
/
intl402
/
NumberFormat
/
throws
-
for
-
maximumFractionDigits
-
over
-
limit
.
js
skip
script
test262
/
intl402
/
NumberFormat
/
throws
-
for
-
minimumFractionDigits
-
over
-
limit
.
js
#
Requires
Unicode
15
Expand Down

0 comments on commit 1cb8981

Please sign in to comment.