Skip to content

Commit

Permalink
Bug 1919114 Part 3: Update fuzziness of reftests with no gpu process.…
Browse files Browse the repository at this point in the history
… r=gfx-reviewers,aosmond,taskgraph-reviewers,jmaher

Allowing (once again) a no-gpu-process option increases the number of
pixels which get antialiased differently than the reference image. The
images continue to largely match; it's just an increase in the number of
close-but-not-quite pixels.

Differential Revision: https://phabricator.services.mozilla.com/D223395

UltraBlame original commit: d64a523fd44caebf75a8b4ff2744ec1c44c5bdb2
  • Loading branch information
marco-c committed Oct 9, 2024
1 parent 45220c0 commit 11ea5cf
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions gfx/layers/apz/test/reftest/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ skip-if(useDrawSnapshot) == frame-reconstruction-scroll-clamping.html frame-reco

# Test that position:fixed and position:sticky elements are attached to the
# layout viewport.
skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) == pinch-zoom-position-fixed.html pinch-zoom-position-fixed-ref.html
skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) == pinch-zoom-position-sticky.html pinch-zoom-position-sticky-ref.html
skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) fuzzy(0-1,0-24) == pinch-zoom-position-fixed.html pinch-zoom-position-fixed-ref.html
skip-if(winWidget&&isCoverageBuild) pref(apz.allow_zooming,true) fuzzy(0-1,0-24) == pinch-zoom-position-sticky.html pinch-zoom-position-sticky-ref.html

pref(apz.allow_zooming,true) == iframe-zoomed.html iframe-zoomed-ref.html
pref(apz.allow_zooming,true) == scaled-iframe-zoomed.html scaled-iframe-zoomed-ref.html
Expand Down
8 changes: 4 additions & 4 deletions layout/reftests/bugs/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ fuzzy(0-1,0-133) == 273681-1.html 273681-1-ref.html
== 283686-2.html 283686-2-ref.html
== 283686-3.html about:blank
== 289384-1.xhtml 289384-ref.xhtml
random-if(winWidget) fuzzy(0-25,0-2148) fails-if(useDrawSnapshot) HTTP == 289480.html#top 289480-ref.html # basically-verbatim acid2 test, HTTP for a 404 page -- bug 578114 for the winWidget failures
random-if(winWidget) fuzzy(0-25,0-2751) fails-if(useDrawSnapshot) HTTP == 289480.html#top 289480-ref.html # basically-verbatim acid2 test, HTTP for a 404 page -- bug 578114 for the winWidget failures
== 290129-1.html 290129-1-ref.html
== 291078-1.html 291078-1-ref.html
== 291078-2.html 291078-2-ref.html
Expand Down Expand Up @@ -1164,7 +1164,7 @@ fuzzy(0-4,0-361) == 449519-1.html 449519-1-ref.html
fails-if(Android) == 455826-1.html 455826-1-ref.html
== chrome://reftest/content/bugs/456147.xhtml 456147-ref.html
fuzzy(24-110,110-800) == 456219-1a.html 456219-1-ref.html # bug 1128229
fuzzy(24-110,107-1251) == 456219-1b.html 456219-1-ref.html # bug 1128229
fuzzy(24-110,107-3200) == 456219-1b.html 456219-1-ref.html # bug 1128229
fuzzy(24-110,107-3800) == 456219-1c.html 456219-1-ref.html # bug 1128229
fuzzy(0-10,0-8) == 456219-2.html 456219-2-ref.html
== 456330-1.gif 456330-1-ref.png
Expand Down Expand Up @@ -2009,7 +2009,7 @@ needs-focus != 1377447-1.html 1377447-2.html
fuzzy(0-129,0-48) == 1406179.html 1406179-ref.html
== 1406183-1.html 1406183-1-ref.html
== 1410028.html 1410028-ref.html
fuzzy-if((!gtkWidget&&!geckoview&&!swgl&&!(isCoverageBuild&&winWidget))||useDrawSnapshot,1-2,17300-17500) skip-if(winWidget&&isCoverageBuild) == 1412375.html 1412375-ref.html # Skip WinCCov: Bug 1740155
fuzzy-if((!gtkWidget&&!geckoview&&!swgl&&!(isCoverageBuild&&winWidget))||useDrawSnapshot,0-2,0-17500) skip-if(winWidget&&isCoverageBuild) == 1412375.html 1412375-ref.html # Skip WinCCov: Bug 1740155
# Note: The test below has a large fuzz, because svg text chooses
# scale-dependent font metrics. Without the fix the test fails in the range
# 246-255,3237-25110, which overlaps the fuzz range, but would still catch
Expand All @@ -2018,7 +2018,7 @@ fuzzy(0-255,0-6025) == 1415987-1.html 1415987-1-ref.html
== 1419820-1.html 1419820-1-ref.html
== 1420946-1.html 1420946-1-ref.html
== 1422393.html 1422393-ref.html
skip-if(winWidget&&isCoverageBuild) == 1424177.html 1424177-ref.html
skip-if(winWidget&&isCoverageBuild) fuzzy(0-1,0-4) == 1424177.html 1424177-ref.html
== 1424680.html 1424680-ref.html
== 1424798-1.html 1424798-ref.html
fuzzy-if(swgl,0-1,0-31430) == 1425243-1.html 1425243-1-ref.html
Expand Down
4 changes: 2 additions & 2 deletions layout/reftests/css-blending/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ fuzzy(0-1,0-1600) == background-blending-exclusion.html background-blending-excl
fuzzy-if(cocoaWidget||winWidget||swgl,0-1,0-1600) == background-blending-hard-light.html background-blending-hard-light-ref.svg
fuzzy-if(winWidget,0-1,0-9600) fuzzy-if(!winWidget,0-1,0-11200) fuzzy-if(!geckoview,1-1,9600-11240) == background-blending-hue.html background-blending-hue-ref.svg
== background-blending-lighten.html background-blending-lighten-ref.svg
fuzzy-if(winWidget,0-1,0-8000) fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-luminosity.html background-blending-luminosity-ref.svg
fuzzy-if(winWidget,0-1,0-9600) fuzzy-if(!winWidget,0-2,0-9600) fuzzy-if(appleSilicon,0-1,0-11200) fuzzy-if(swgl&&!Android,1-1,8000-9600) == background-blending-luminosity.html background-blending-luminosity-ref.svg
fuzzy(0-1,0-1600) == background-blending-multiply.html background-blending-multiply-ref.svg
== background-blending-normal.html background-blending-normal-ref.svg
fuzzy-if(!winWidget,0-1,0-1600) == background-blending-overlay.html background-blending-overlay-ref.svg
fuzzy(0-1,0-1600) == background-blending-overlay.html background-blending-overlay-ref.svg
fuzzy-if(winWidget,0-1,0-3200) fuzzy-if(!winWidget,0-2,0-12800) == background-blending-saturation.html background-blending-saturation-ref.svg
fuzzy(0-1,0-1600) == background-blending-screen.html background-blending-screen-ref.svg
fuzzy(0-10,0-4800) == background-blending-soft-light.html background-blending-soft-light-ref.svg
Expand Down
4 changes: 2 additions & 2 deletions layout/reftests/svg/as-image/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ fuzzy-if(winWidget,0-1,0-10000) test-pref(svg.context-properties.content.enabled
== img-simple-2.html lime100x100-ref.html
fuzzy(0-255,0-350) fuzzy-if(geckoview,0-255,0-4063) == img-simple-3.html img-simple-3-ref.html #Bug 1564891, bug 1574154
== img-simple-4.html lime100x100-ref.html
fuzzy(0-255,0-90) fuzzy-if(geckoview,0-255,0-1268) == img-simple-5.html img-simple-5-ref.html
fuzzy(0-255,0-90) fuzzy-if(geckoview,0-255,0-1286) == img-simple-5.html img-simple-5-ref.html
== img-simple-6.html lime100x100-ref.html
fuzzy(0-255,0-27) == img-simple-7.html img-simple-7-ref.html

Expand All @@ -120,7 +120,7 @@ fuzzy-if(winWidget,0-16,0-10) == img-content-outside-viewBox-1.html img-content-
# img-foreignObject-iframe-1a.html, though, because its SVG image tries to
# alert(), and that'd trigger a reftest timeout if we loaded that file directly.
== img-foreignObject-embed-1.html lime100x100-ref.html
skip != img-foreignObject-embed-1-helper.svg lime100x100.svg # Bug 1708599
skip != img-foreignObject-embed-1-helper.svg lime100x100.svg # Bug 1708599
== img-foreignObject-iframe-1a.html lime100x100-ref.html
== img-foreignObject-iframe-1b.html lime100x100-ref.html
!= img-foreignObject-iframe-1b-helper.svg lime100x100.svg
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/svg/filters/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ fuzzy(0-1,0-400) == feDisplacementMap-alpha-01.svg pass.svg
fuzzy(0-2,0-500) == feDisplacementMap-colour-01.svg feDisplacementMap-colour-01-ref.svg
== feDisplacementMap-scale-01.svg pass.svg

fuzzy-if(winWidget,0-2,0-25) fuzzy-if(Android13&&aarch64,6-6,4549-4549) fuzzy-if(!useDrawSnapshot,55-98,14033-16467) fuzzy-if(gfxSVGFEDropShadow&&!gfxSVGFEOffset,97-98,21500-22951) fuzzy-if(gfxSVGFEOffset,0-2,0-1000000) == feDropShadow-01.svg feDropShadow-01-ref.svg
fuzzy-if(winWidget,0-2,0-25) fuzzy-if(Android13&&aarch64,6-6,4549-4549) fuzzy-if(!useDrawSnapshot,55-98,14033-16467) fuzzy-if(gfxSVGFEDropShadow&&!gfxSVGFEOffset,97-98,21500-22951) fuzzy-if(gfxSVGFEOffset,0-6,0-1000000) == feDropShadow-01.svg feDropShadow-01-ref.svg

== feFlood-color-01.svg pass.svg

Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/svg/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ fuzzy-if(winWidget,0-16,0-5) == paint-order-01.svg paint-order-01-ref.svg
== paint-order-02.svg paint-order-02-ref.svg
== paint-order-03.svg paint-order-03-ref.svg

fuzzy(0-54,0-77) == path-01.svg path-01-ref.svg
fuzzy(0-54,0-80) == path-01.svg path-01-ref.svg
== path-02.svg pass.svg
== path-04.svg pass.svg
== path-05.svg pass.svg
Expand Down
2 changes: 1 addition & 1 deletion layout/reftests/transform/reftest.list
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animati
test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-4.html partial-prerender-expansion-ref.html
# This reftest doesn't fail on WebRender, this reftest fails only if there is a jank mechanism and the mechanism does inproperly handle position:fixed scroll target
test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-5.html partial-prerender-translate-5-ref.html
skip-if(useDrawSnapshot) test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-46,0-1250) fuzzy-if(Android,0-255,0-9900) random-if(gtkWidget&&isDebugBuild) random-if(useDrawSnapshot) == partial-prerender-translate-6.html partial-prerender-translate-6-ref.html
skip-if(useDrawSnapshot) test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-250,0-1250) fuzzy-if(Android,0-255,0-9900) random-if(gtkWidget&&isDebugBuild) random-if(useDrawSnapshot) == partial-prerender-translate-6.html partial-prerender-translate-6-ref.html
test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") fuzzy(0-4,0-1200) == partial-prerender-translate-7.html partial-prerender-translate-2-ref.html
# This reftest doesn't fail on WebRender, this reftest fails only if there is a jank mechanism and the mechanism doesn't properly clip transform in iframes.
test-pref(layout.animation.prerender.partial.jank,true) test-pref(layout.animation.prerender.partial,true) test-pref(layout.animation.prerender.viewport-ratio-limit,"1.125") == partial-prerender-translate-8.html partial-prerender-translate-8-ref.html
Expand Down

0 comments on commit 11ea5cf

Please sign in to comment.