Integration setup - advice on use of an access token rather than API_SECRET #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed change to advise on use of an access token rather than API_SECRET, Provide link to nightscout guide.
Proposed change to advise on use of an access token rather than API_SECRET, Provide link to nightscout guide.
advise on use of an access token rather than API_SECRET
marciogranzotto
pushed a commit
that referenced
this pull request
Nov 21, 2021
* Remove old migrations from KNX integration * Remove cover migration
marciogranzotto
pushed a commit
that referenced
this pull request
Dec 30, 2021
* Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Bump aioshelly * Bump fritzconnection and remove workarounds * Cleanup fritzbox_callmonitor * Rework device_info * Update device_info via registry * Optimized checks: only when needed * Revert device_info rework as not needed * Fix reboot detection for all scenarios * Final optimization * Remove leftover * Update homeassistant/components/shelly/utils.py Co-authored-by: Shay Levy <[email protected]> * Update homeassistant/components/shelly/__init__.py Co-authored-by: Shay Levy <[email protected]> * Revert slipped in commit * Rename param * Apply review comment * Apply comment review #2 Co-authored-by: Shay Levy <[email protected]>
marciogranzotto
approved these changes
Mar 11, 2022
marciogranzotto
pushed a commit
that referenced
this pull request
May 25, 2022
* First version of laundrify integration * Code cleanup * Code cleanup after review #2 * Move coordinator to its own file * Save devices as dict and implement available prop as fn * Validate token on init, abort if already configured * Some more cleanup after review * Add strict type hints * Minor changes after code review * Remove OptionsFlow (use default poll interval instead) * Fix CODEOWNERS to pass hassfest job * Fix formatting to pass prettier job * Fix mypy typing error * Update internal device property after fetching data * Call parental update handler and remove obsolete code * Add coordinator tests and fix some config flow tests * Refactor tests * Refactor fixtures * Device unavailable if polling fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change for integration setup to advise on use of an access token rather than API_SECRET, Provide link to nightscout guide.
p.s. Thanks @marciogranzotto for your inclusion of mmol/L, much appreciated. Looking forward to when it gets pushed to core. Works well on my test setup.