Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos #4

Merged
merged 5 commits into from
Aug 31, 2024
Merged

Fix Typos #4

merged 5 commits into from
Aug 31, 2024

Conversation

limuy2022
Copy link
Contributor

Hello! I've noticed there are numerous spelling errors in your code. I have corrected them and added the corresponding GitHub action for the spell checker. Please review my changes carefully, as many of the corrections were made based on my assumptions and may not be accurate. Additionally, I was unable to compile this project in my Linux environment, so there might be compilation errors after my modifications. Please be cautious!

@marci1175 marci1175 self-assigned this Aug 30, 2024
README.md Outdated
@@ -38,8 +38,8 @@ _________________________________________________________
- Navigate to `desktop/Installer` in the project folder, and open up the Matthias.sln file.
- Click on build on the top menu bar and click Build Solution (Or use the `ctrl+shift+b` key combination)
- After building go to `desktop/Installer/MatthiasSetup/Release/` and you will find two files:
- One containing the dependencies (Smaller file size)
- One containing the application itself (Bigger file size)
- One containingg the dependencies (Smaller file size)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this typo, its also present in desktop/src/app/ui/client_ui/client_actions/audio_recording.rs.


jobs:
build:
runs-on: ubuntu-latest
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change ˙ubuntu-latest˙ to ˙windows-latest˙, since my project doesnt compile to linux as of now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a spell checker,not a compilation process.So choosing ubuntu will run this action faster than choosing windows.

Copy link
Owner

@marci1175 marci1175 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo "everythingg" in all files (I didnt make a comment at every one of them).
Please change "abnormal" to "a normal" I have created a comment at most of them but please check to make sure.

After these this pull request is ready to be merged!

@@ -158,7 +158,7 @@ impl Application

//Draw background
ui.painter().rect_filled(
Rect::everything_right_of(ui.available_width()),
Rect::everythingg_right_of(ui.available_width()),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix function name typo

@@ -155,7 +155,7 @@ impl Application

//Draw background
ui.painter().rect_filled(
Rect::everything_right_of(ui.available_width()),
Rect::everythingg_right_of(ui.available_width()),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix function name typo here

@@ -413,7 +413,7 @@ impl Application
if item.uuid == self.opened_user_information.uuid
&& item.message_type != ServerMessageType::Deleted
{
//We should only display the `edit` button if its anormal message thus its editable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "a normal" from "abnormal"

@@ -379,7 +379,7 @@ impl Application
if item.uuid == self.opened_user_information.uuid
&& item.message_type != ServerMessageType::Deleted
{
//We should only display the `edit` button if its anormal message thus its editable
//We should only display the `edit` button if its abnormal message thus its editable
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "a normal"

@@ -100,7 +100,7 @@ impl Application
)));

if disconnect_button.clicked() {
//Disable camera if it exists before everything else
//Disable camera if it exists before everythingg else
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typos present in this file regarding "everythingg"

@@ -512,10 +512,10 @@ impl backend::Application

let user_information = self.opened_user_information.clone();

//Reset all messages and everything else
//Reset all messages and everythingg else
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix typo "everythingg" present in all files.

@limuy2022
Copy link
Contributor Author

please don't use "its" instead of "it's" anymore.I misunderstood your meaning,sorry

@marci1175 marci1175 merged commit f31aef6 into marci1175:main Aug 31, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants