jsx-no-duplicate-props: TypeError: name.toLowerCase is not a function j…

…sx-eslint#969 - recommended improvement - add test
marcelmokos · Jul 21, 2017 · 6112149 · 6112149 · DianaSuvorova · Jul 23, 2017
1 parent dd20a7a
commit 6112149
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/rules/jsx-no-duplicate-props.js b/lib/rules/jsx-no-duplicate-props.js
@@ -45,7 +45,11 @@ module.exports = {
 
           let name = decl.name.name;
 
-          if (ignoreCase && typeof name === 'string') {
+          if (typeof name !== 'string') {
+            return;
+          }
+
+          if (ignoreCase) {
             name = name.toLowerCase();
           }
 

diff --git a/tests/lib/rules/jsx-no-duplicate-props.js b/tests/lib/rules/jsx-no-duplicate-props.js
@@ -49,7 +49,8 @@ ruleTester.run('jsx-no-duplicate-props', rule, {
     {code: '<App c="a" {...this.props} a="c" b="b" />;'},
     {code: '<App A a />;'},
     {code: '<App A b a />;'},
-    {code: '<App A="a" b="b" B="B" />;'}
+    {code: '<App A="a" b="b" B="B" />;'},
+    {code: '<App a:b="c" />;', options: ignoreCaseArgs}
   ],
   invalid: [
     {code: '<App a a />;', errors: [expectedError]},