Bugfix/devise #12
Merged
Bugfix/devise #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devise default hashing algorithm Bcrypt uses only 72 bytes of data in order to create a password hash. Rest of it is truncated, leading to some potential serious security vulnerabilities.
marcel-strzalka
force-pushed
the
bugfix/devise
branch
from
f465ecc to
298e834
Compare
kodowicz
reviewed
Oct 5, 2022
|
|
||
| # ==> Mailer Configuration | ||
| # Configure the e-mail address which will be shown in Devise::Mailer, | ||
| # note that it will be overwritten if you use your own mailer class | ||
| # with default "from" parameter. | ||
| config.mailer_sender = 'please-change-me-at-config-initializers-devise@example.com' | ||
| config.mailer_sender = 'manager@montecinema.com' |
There was a problem hiding this comment.
Sure, I'll leave that as it is for now and gonna get back to it when I prepare my app for deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Changes default hashing algorithm fromBcrypttoArgon2in order to avoid problems with passwords with too many bytes. More about this issue can be found here. I also removed support for salt in User model, becauseArgon2similarly toBcrypt, stores the salt in the password hash.Changes minimum password length to 10.TurboControllerandTurboFailureAppclasses are a part of it.Hashing with Argon2 was implemented with help of these 2 following gems:devise-encryptabledevise-argon2Edit: After talking with Rafał I was made aware of the fact that I shouldn't use
devise-argon2library, because it usesArgon2hashing algorithms in an invalid way. Instead I decided to simply add a validation to User model that checks if thebytesizeof password is not too long (Bcrypt will truncate any data after consuming 72 bytes, leading to potential problems).