You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we want some datatypes used by marbl_interface_class defined in marbl_interface_types.F90 and others defined in marbl_internal_types.F90 with the distinction being:
Datatypes that are used by the GCM driver (explicitly via a use statement) should be in marbl_interface_types.F90, all others belong in marbl_internal_types.F90.
This will require some clean-up, as many of the datatypes in marbl_interface_types.F90 are not explicitly used by the driver (rather, the derived types appear as components of marbl_instance).
This will not affect the API at all, but it would be nice to be consistent before the 1.0.0 release.
The text was updated successfully, but these errors were encountered:
This ticket still stands, though: we need to come up with clear criteria for when to put derived types in each of these files (vs defining them in a separate module). I think this fits nicely in the "freeze development" column because it may result in some massive refactoring.
I think we want some datatypes used by
marbl_interface_class
defined inmarbl_interface_types.F90
and others defined inmarbl_internal_types.F90
with the distinction being:use
statement) should be inmarbl_interface_types.F90
, all others belong inmarbl_internal_types.F90
.This will require some clean-up, as many of the datatypes in
marbl_interface_types.F90
are not explicitly used by the driver (rather, the derived types appear as components ofmarbl_instance
).This will not affect the API at all, but it would be nice to be consistent before the 1.0.0 release.
The text was updated successfully, but these errors were encountered: