You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the convention for when to name something marbl_... should be limited to
All Fortran file names should have the marbl_ prefix
All public subroutines in marbl_XYZ_mod.F90 should have the marbl_XYZ_ prefix, which obviously includes the marbl_ prefix by definition
The datatypes of all public variables in marbl_interface_class should be marbl_..._type
For example a GCM might want a subroutine to process diagnostic output, and should be able to pass a marbl_diagnostics_type object
So the datatypes in marbl_interface_private_type.F90 are not meant to be accessible to the GCM (e.g. marbl_instance%PAR is private) and therefore do not need the marbl_ prefix.
Note that similar logic points towards dropping the marbl_ prefix from the following subroutines in marbl_mod.F90:
I think the convention for when to name something
marbl_...
should be limited toAll Fortran file names should have the
marbl_
prefixAll public subroutines in
marbl_XYZ_mod.F90
should have themarbl_XYZ_
prefix, which obviously includes themarbl_
prefix by definitionThe datatypes of all public variables in
marbl_interface_class
should bemarbl_..._type
marbl_diagnostics_type
objectSo the datatypes in
marbl_interface_private_type.F90
are not meant to be accessible to the GCM (e.g.marbl_instance%PAR
is private) and therefore do not need themarbl_
prefix.Note that similar logic points towards dropping the
marbl_
prefix from the following subroutines inmarbl_mod.F90
:The text was updated successfully, but these errors were encountered: