Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how stand-alone driver reports timers results (also improve mpi implementation) #336

Open
mnlevy1981 opened this issue May 15, 2019 · 0 comments

Comments

@mnlevy1981
Copy link
Collaborator

I'm nearly done fixing #156 and that work has highlighted a shortcoming in how the stand-alone driver reports timing results: the branch allows multiple columns to be split among multiple marbl instances, but the timer summary in the driver was designed with a single instance in mind. I think the proper solution would be to report the sum of each timer over all the instances.

Also, the current MPI implementation duplicates instances on the different tasks. Ideally, the different instances of this new test would be distributed (in which case the timer summary needs to know which instances belong to which task when summarizing the results).

It may make sense to split this issue in two, and handle the MPI work separately from the timers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant