You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Testing for many issues (#41 and #146 stand out) would be easier if we had a simple test that initialized the model, called marbl_instance%set_surface_forcing and marbl_instance%set_interior_forcing, and then wrote the diagnostic output.
This would require a couple of things that we don't have right now:
Datasets (initial conditions, forcing files, etc), and a way to provide them to users (some sort of inputdata repository?)
An IO module that can parse the diagnostics type and write netCDF output (CVMix has one that would be a great starting point)
The text was updated successfully, but these errors were encountered:
I've been working on this test, and one thing I haven't been happy with how I've added netCDF to the build. @matt-long pointed out that one possibility is to use Docker to construct a virtual machine with gfortran and netcdf and then it should be easy to update the Makefile to build because the docker environment will be the same regardless of host machine. The picture in my head about this right now is pretty vague, but I think having a docker build target in the Makefile and a way for test suite to know it is running in the VM would work.
Something else that came to me as I was typing this ticket is that I could also add some netcdf build options to machines.py so we could also test on Cheyenne with ifort (for example). Combining these two thoughts, maybe --machine docker would be a new supported option for the python scripts.
FYI, I set up a kanban-style project board in my fork to track progress and what needs to be done. It looks like I should read through my old comments here and make sure that board covers everything I wanted to do.
As soon as the TravisCI tests are passing (see mnlevy1981#17) I'll submit a pull request. It probably makes sense to split the code review into two pieces -- one for the Fortran changes, and one for the changes on the testing side / updated documentation. Aside from the failed Travis build, the Fortran is ready to be looked at.
Testing for many issues (#41 and #146 stand out) would be easier if we had a simple test that initialized the model, called
marbl_instance%set_surface_forcing
andmarbl_instance%set_interior_forcing
, and then wrote the diagnostic output.This would require a couple of things that we don't have right now:
The text was updated successfully, but these errors were encountered: