-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick fixes for dashboard #51
Conversation
Whether plotting images from glade or webext, use the same bulk of the notebook (just set paths differently based on an if statement)
I'll take this out of draft mode when all three components of the issue are addressed |
top-level keys must match plot_type in the data frame, subkeys are just kwargs for panelify.create_dashboard
Some more cleanup of the dashboard notebook, mostly in the markdown cells but I also combined some of the computational cells to streamline things a bit.
I updated the documentation inside this notebook; should I also update the top-level |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - we can add the documentation to the README in another PR...
1. Include trend_map panel 2. Remove commented out lines (from storage_option) 3. Add sel_dict dropdown menus to most of the dashboard pages The last update causes some unwanted behavior -- see marbl-ecosys#52 for details, but basically it requires changing two dropdown menus when switching between a 2D and 3D variable (the variable dropdown, and then selecting appropriate z_t or z_t_150m value); it also leads to an empty frame when it first runs since the default values populating summary_map are Varname = CaCO3_FLUX_100m and Sel_dict = '{z_t: 35109.35}' when that specific variable is only plotted with sel_dict = {}
@mnlevy1981 feel free to merge when you are ready! |
No need for separate sections of the notebook for glade and webext; also clean up the dashboard itself: remove blue side panel, and move some of the dashboard setup code to a YAML file.
Fixes #49