Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queries should not fail when user doesn't have default currency #272

Closed
maraf opened this issue Apr 11, 2020 · 0 comments
Closed

Queries should not fail when user doesn't have default currency #272

maraf opened this issue Apr 11, 2020 · 0 comments
Assignees
@maraf
Labels
api bug
Milestone
api-v1.4.0

Comments

@maraf
Copy link
Owner

maraf commented Apr 11, 2020

Test on GetTotalMonthOutcome which throws NRE when default currency is missing.
@maraf maraf added this to the api-v1.3.1 milestone Apr 11, 2020
@maraf maraf changed the title Queries should not faild when user doesn't have default currency Queries should not fail when user doesn't have default currency Apr 11, 2020
@maraf maraf self-assigned this Aug 25, 2020
maraf added a commit that referenced this issue Aug 25, 2020
@maraf
#272 - Throw user exception instead of NullReferenceException.
bf8f68f
maraf added a commit that referenced this issue Aug 25, 2020
@maraf
#272 - Returning same exception info from query api as from command api.
8776f74
@maraf maraf closed this as completed Aug 25, 2020
maraf added a commit that referenced this issue Aug 31, 2020
@maraf
#272 - Use FindDefaultCurrency in PriceCalculator.
949e568
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maraf maraf

Labels
api bug
Projects
None yet
Milestone
api-v1.4.0
Development

No branches or pull requests
1 participant
@maraf