Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a prompt when GeometryCollection is nested within itself #2142

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

deyihu
Copy link
Collaborator

@deyihu deyihu commented Nov 29, 2023

fix #2141

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (52355ee) 83.60% compared to head (03eb37c) 83.64%.

Files Patch % Lines
src/geometry/GeometryCollection.js 75.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2142      +/-   ##
==========================================
+ Coverage   83.60%   83.64%   +0.03%     
==========================================
  Files         168      168              
  Lines       18702    18710       +8     
==========================================
+ Hits        15636    15650      +14     
+ Misses       3066     3060       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fuzhenn fuzhenn merged commit f39a18b into maptalks:master Dec 19, 2023
@deyihu deyihu deleted the 2141 branch December 19, 2023 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a prompt when GeometryCollection is nested within itself
3 participants