Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libGDX] 1.9.10 -> 1.11.0 #972

Closed
wants to merge 1 commit into from
Closed

Conversation

wolfgang-ch
Copy link

This PR contains modifications to run VTM with libGDX 1.11.0

I've tested org.oscim.test.MapsforgeTest with Windows 10 sucessfully, it also worked in my project MyTourbook with Windows and Linux

This was the settings.gradle which I used to build it, I disabled all includes which I cannot test/build. I use this modified setup also in my project.

I think, that porting to the other platforms should not be much work

image

[VTM] Fixed libGDX API changes
[VTM] Fixed libGDX API changes
Copy link
Collaborator

@devemux86 devemux86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, however the build fails.

That's why mentioned that updating libGDX requires VTM changes.
Pull requests must build successfully all modules.

Android is an important platform of VTM, can test it on Android emulator.

@wolfgang-ch
Copy link
Author

Something went wrong with your comment, it's not available any more

image

My Answer:

This error occurred with Java 7

image

@wolfgang-ch
Copy link
Author

Pull requests must build successfully all modules.

I cannot fulfill these requirements, I've zero Android experience and no iOS/OSX to test it, I close this PR and maybe someone else can cherry pick this commit

@devemux86
Copy link
Collaborator

devemux86 commented Nov 14, 2022

This error occurred with Java 7

Then the required module could be updated, but not all platforms.

I've zero Android experience and no iOS/OSX to test it, I close this PR and maybe someone else can cherry pick this commit

I don't have Mac access either, but the modules have to be built or the library can't be published.

I may check for a newer libGDX version when time is available.

devemux86 pushed a commit that referenced this pull request Nov 15, 2022
devemux86 added a commit that referenced this pull request Nov 15, 2022
@devemux86 devemux86 added this to the 0.19.0 milestone Nov 15, 2022
@devemux86
Copy link
Collaborator

Thanks, merged via 36e4116 and fixed the other platforms via e1191f6.

(for iOS see MobiVM/robovm#394 (comment))

@wolfgang-ch
Copy link
Author

This error occurred with Java 7

Then the required module could be updated, but not all platforms.

My gradle skills are not so good to apply the best changes but I've seen that you have done it in your commit 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants