Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement iOS Framework "SVGgh" for SVG rendering on iOS #69

Closed
wants to merge 2 commits into from
Closed

Implement iOS Framework "SVGgh" for SVG rendering on iOS #69

wants to merge 2 commits into from

Conversation

Longri
Copy link

@Longri Longri commented Jul 17, 2016 •
edited
Loading

implement iOS Framwork "SVGgh" for svg rendering on iOS

@Longri Longri closed this Jul 17, 2016
@devemux86
Copy link
Collaborator

devemux86 commented Jul 17, 2016 •
edited
Loading

natives subfolder is supposed to hold the natives libraries needed at runtime.
It's archived each time as separate artifact.
So what's the need for all these new stuff there, the headers etc. ?

@Longri
Copy link
Author

Longri commented Jul 17, 2016

that's the iOS framework "SVGgh"!
For compile iOS, this framework will compile into the *.ipa!
All is needed!

@Longri
Copy link
Author

Longri commented Jul 17, 2016

sorry, I closed on my Fork

@Longri Longri reopened this Jul 17, 2016
@devemux86
Copy link
Collaborator

devemux86 commented Jul 17, 2016 •
edited
Loading

When it's compiled?
At runtime we'll have the headers inside the app?

@Longri
Copy link
Author

Longri commented Jul 17, 2016

No! On iOS, we have no jit compiler! iOS has an ahead-of-time compiler

@devemux86
Copy link
Collaborator

devemux86 commented Jul 17, 2016 •
edited
Loading

Can you run gradle install and then check the created vtm-ios-0.6.0-SNAPSHOT-natives.jar artifact in your local Maven repository?
That's what will go into Maven Central, does it have the right structure?

@Longri
Copy link
Author

Longri commented Jul 17, 2016

the created vtm-ios-0.6.0-SNAPSHOT-natives.jar artifact is correct!

But wait with merging! I will write a README.md to explain usage this vtm-ios-0.6.0-SNAPSHOT-natives.jar, and put this to folder vtm-ios. Or is it better to write it to regular README?

but not today, family is waking up! ;-)

@devemux86
Copy link
Collaborator

devemux86 commented Jul 17, 2016 •
edited
Loading

Ok just wanted to double ckeck. 😄

We can put child readme guides in a root docs subfolder with links in main page (line in Mapsforge).
So you can create there a readme with a regular name e.g. ios.md.

BTW is it time to remove the "experimental" reference for vtm-ios?

@devemux86 devemux86 added this to the 0.6.0 milestone Jul 17, 2016
devemux86
devemux86 reviewed Jul 17, 2016
View reviewed changes
vtm-ios/src/org/oscim/ios/backend/IosSvgBitmap.java
SVGRenderer renderer = new SVGRenderer(svg);
CGRect viewRect = renderer.getViewRect();

float scaleFactor = CanvasAdapter.dpi / 240;
Copy link
Collaborator

@devemux86 devemux86 Jul 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that in AndroidSvgBitmap I found the scaleFactor calculation with 240dpi to produce small symbols, that's why I used the regular 160dpi as base.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have copy/paste from Desktop!
I will check the display with 160dpi and maybe change! On simulator 240dpi looks good.

@devemux86
Copy link
Collaborator

@Longri do you have additional work on this?

@Longri
Copy link
Author

Longri commented Jul 19, 2016

No, but I would do this on this week

@Longri
Copy link
Author

Longri commented Jul 19, 2016

or today

@devemux86
Copy link
Collaborator

Ok!
Have you review the 160 or 240 above, which is appropriate for iOS?

@Longri
Copy link
Author

Longri commented Jul 19, 2016

yes! for iPhone 4s the display is ok! But I will check this again when I have a Android devices with similar Display size

devemux86 added a commit that referenced this pull request Jul 19, 2016
@devemux86
Render themes: SVG resources on iOS, improves #69
21ea5a7
@devemux86
Copy link
Collaborator

devemux86 commented Jul 19, 2016 •
edited
Loading

@Longri thanks for the work on this!

Squashed and merged via 4c5de74.
I also added a link for the guide on main page.

@devemux86 devemux86 closed this Jul 19, 2016
@devemux86 devemux86 changed the title implement iOS Framwork "SVGgh" for svg rendering on iOS Implement iOS Framework "SVGgh" for SVG rendering on iOS Jul 19, 2016
@devemux86 devemux86 mentioned this pull request Jul 19, 2016
Closed
@Longri Longri deleted the iOSsvg branch October 1, 2016 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Longri @devemux86