Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewController: refactor 'setScreenSize' with 'setViewSize' #523

Closed
wants to merge 2 commits into from

Conversation

Gustl22
Copy link

@Gustl22 Gustl22 commented Apr 12, 2018

Method does not set screen size, only the frame view. So I changed the name. I think no one used this method...

@Gustl22 Gustl22 changed the title ViewController_refactor 'setScreenSize' with 'setFrameSize' ViewController: refactor 'setScreenSize' with 'setFrameSize' Apr 12, 2018
@devemux86
Copy link
Collaborator

Better use ViewSize to be more close to View or MapView terms?

@Gustl22 Gustl22 changed the title ViewController: refactor 'setScreenSize' with 'setFrameSize' ViewController: refactor 'setScreenSize' with 'setViewSize' Apr 12, 2018
@Gustl22
Copy link
Author

Gustl22 commented Apr 12, 2018

Updated PR :)

@devemux86 devemux86 added this to the 0.10.0 milestone Apr 14, 2018
devemux86 pushed a commit that referenced this pull request Apr 14, 2018
@devemux86
Copy link
Collaborator

Thanks!
Squashed and merged via d7aad27.

@devemux86 devemux86 closed this Apr 14, 2018
@Gustl22 Gustl22 deleted the screen branch April 14, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants