Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texture atlas: use bitmap packer based on libGdx PixmapPacker #304

Closed
wants to merge 2 commits into from
Closed

Texture atlas: use bitmap packer based on libGdx PixmapPacker #304

wants to merge 2 commits into from

Conversation

Longri
Copy link

@Longri Longri commented Feb 26, 2017 •
edited
Loading

When looking at the error in #301 , I have seen that the Atlas Images were not always optimally packed. Therefore I looked at the PixmapPacker of LibGdx and ported this to a use with Bitmap's!

@Longri Longri mentioned this pull request Feb 28, 2017
Closed
@devemux86
Copy link
Collaborator

devemux86 commented Feb 28, 2017 •
edited
Loading

@Longri can you check the PR state?
I find it not working correctly on AtlasMarkerLayerTest and AtlasMarkerOverlayActivity samples.
When pressing a marker then the same icon is used instead of the focus one.

@devemux86 devemux86 mentioned this pull request Feb 28, 2017
Closed
@Longri
Copy link
Author

Longri commented Feb 28, 2017

You are right, this only occurs if the Bug #301 not fixed!
In attempting to calculate the optimal size of the atlases, I have lost.
Therefore two small atlases will created. With two atlases it will not work without fix the bug #301.
I will rework the calculation of size and choose a POW2 size which is better for OpenGl!

@Longri
* fix calculation of atlas size
e681805 
* use POT for atlas size
@Longri
Copy link
Author

Longri commented Feb 28, 2017

now it will calculate correct! Thanks for the hint!

@devemux86 devemux86 changed the title Improve packer! Ported LibGdx PixmapPacker to use Vtm's Bitmap. Without any LibGdx dependencies Texture atlas: use bitmap packer based on libGdx PixmapPacker Mar 1, 2017
@devemux86 devemux86 added this to the 0.8.0 milestone Mar 1, 2017
devemux86 pushed a commit that referenced this pull request Mar 1, 2017
@Longri @devemux86
Texture atlas: use bitmap packer based on libGdx PixmapPacker (#304)
23d34fa
@devemux86
Copy link
Collaborator

Thanks!
Merged via 23d34fa.

@devemux86 devemux86 closed this Mar 1, 2017
@Longri Longri deleted the improve_bmp_packer branch March 29, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Longri @devemux86