Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location texture renderer #547

Closed
devemux86 opened this issue May 29, 2018 · 17 comments
Closed

Location texture renderer #547

devemux86 opened this issue May 29, 2018 · 17 comments
Milestone

Comments

@devemux86
Copy link
Collaborator

Implement a new separate location renderer using a regular bitmap as marker.

That way users can more easily customize location marker in their applications.

@Longri
Copy link

Longri commented May 29, 2018

Maybe I can PR my used LocatioLayer.
It's ready for use with BMP for location and use the original circle layer as accuracy indicator

@devemux86
Copy link
Collaborator Author

Sure!

use the original circle layer as accuracy indicator

Do you mean a GL circle shader or a regular circle overlay?

@Longri
Copy link

Longri commented May 29, 2018

Modified shader without direction

@Longri
Copy link

Longri commented May 29, 2018

screenshot_2018-05-29-17-31-37

@Longri
Copy link

Longri commented May 30, 2018

Status: in process

I will simplify the layer a little bit and add some properties for the color, which I coded in my shader.

@devemux86
Copy link
Collaborator Author

devemux86 commented May 30, 2018

Note that should not have any bitmap resources in the library.
Users can set marker bitmap during layer creation (like in mapsforge/mapsforge#1035).

@Longri
Copy link

Longri commented May 30, 2018

Note that should not have any bitmap resources in the library.

Of course. Only on example

@devemux86 devemux86 changed the title Location renderer bitmap marker Location renderer texture marker Jun 1, 2018
@devemux86 devemux86 changed the title Location renderer texture marker Location texture renderer Jun 1, 2018
@devemux86 devemux86 added this to the 0.10.0 milestone Jun 1, 2018
@devemux86
Copy link
Collaborator Author

Implemented via #548.

@devemux86
Copy link
Collaborator Author

devemux86 commented Jun 1, 2018

Further improvements could be:

  • Use simpler SVG read implementation in sample with better scaling
    (i.e. AndroidSvgBitmap and friends are focused on theme svg resources)
  • Location marker should tilt following the map movement
  • Shaders could need mediump precision because of My location marker is rendered badly/pixeled #207

@Longri
Copy link

Longri commented Jun 1, 2018

Location marker should tilt following the map movement

I'll have another look, because in my original implementation, in my app, it worked.

Something must have gone wrong when we make the switch.

@devemux86
Copy link
Collaborator Author

Use simpler SVG read implementation in sample with better scaling
(i.e. AndroidSvgBitmap and friends are focused on theme svg resources)

None of these are necessary, just need to scale the size, I pushed the fix.

@Longri
Copy link

Longri commented Jun 2, 2018

Location marker should tilt following the map movement

Okay, I looked in again and I realized that it didn't work for me either. It was just an optical illusion.

Symbols are never tilted.
Although it works with texts/labels.

I think a general property for SymbolItems should be created here with a new issue!?

@devemux86
Copy link
Collaborator Author

devemux86 commented Jun 2, 2018

SymbolItem already supports optional billboard rendering, can see MarkerOverlayActivity.
I pushed the fix.

@Longri
Copy link

Longri commented Jun 2, 2018

Thanks for a broad hint!

But I think is better to use a propertie for that,
so the user can decide.

@devemux86
Copy link
Collaborator Author

If have the location symbol as billboard how does it work?
e.g. with location bearing=0° the arrow should point to North, even with map rotation.
Without billboard that works (1st image), with billboard is always upright on screen (2nd image)

location

@Longri
Copy link

Longri commented Jun 2, 2018

I can't confirm that.

The direction under the Android LocationTextureActivity comes from the GPS. Maybe there's no movement.
It works with my GPS simulator. See Screenshots
bildschirmfoto 2018-06-02 um 14 19 29
bildschirmfoto 2018-06-02 um 14 19 02

@Longri
Copy link

Longri commented Jun 2, 2018

btw.: add billboard rendering propertie for LocationTextureRenderer #549

devemux86 added a commit that referenced this issue Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants