fix isArchived and isGlobal filtering in extendFind endpoint #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2025
|
CollinBeczak
deleted the
Collin/fix-isarchived-and-isglobal-filtering2
branch
jschwarz2030
pushed a commit
that referenced
this pull request
Feb 11, 2025
* fix isArchived and isGlobal filtering in extendFind endpoint * fix spelling error * set the default of isGlobal to true * fix issue with string values, convert them to booleans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: maproulette/maproulette3#2532
Issue
The /api/v2/challenges/extendedFind endpoint was not correctly handling archived and global challenge filtering. The issue arose because the filter condition was always evaluating as false. This happened because the filter was being wrapped in Some(value) (e.g., Some(false) or Some(true)) instead of directly evaluating the value.
Fix Details
This PR updates the condition to handle the wrapped Some(value) correctly, ensuring that the filtering logic now behaves as expected. This is done by adding a default to the variable being filtered. This resolves the bug affecting archived and global challenge filtering.