Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curie_map element to data model #349

Closed
wants to merge 6 commits into from
Closed

Add curie_map element to data model #349

wants to merge 6 commits into from

Conversation

matentzn
Copy link
Collaborator

@matentzn matentzn commented Feb 6, 2024

Resolves #225

  • docs/ have been added/updated if necessary
  • make test has been run locally
  • tests have been added/updated (if applicable)
  • CHANGELOG.md has been updated.

If you are proposing a change to the SSSOM metadata model, you must

  • provide a full, working and valid example in examples/
  • provide a link to the related GitHub issue in the see_also field of the linkml model
  • provide a link to a valid example in the see_also field of the linkml model
  • Update the spec to reflect the fact that the curie_map is now part of the model

This PR adds the curie_map as an official property to the SSSOM data model.

For testing this, I followed @gouttegd great docs. But I also ran some of my own, local tests to ensure that sssom-py does not break.

@matentzn matentzn marked this pull request as ready for review August 3, 2024 06:30
@matentzn matentzn requested review from gouttegd and hrshdhgd August 3, 2024 06:43
@matentzn
Copy link
Collaborator Author

matentzn commented Aug 3, 2024

Oops closing.. #376

Missed this.

@matentzn matentzn closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New metadata element]: MappingSet.curie_map
1 participant