Don't rely on process.env.hasOwnProperty #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oesn't work like a proper JS object. ``` $ node -v v0.8.28 $ node > typeof process.env 'object' > typeof process.env.hasOwnProperty 'undefined' ``` See: nodejs/node-v0.x-archive#3521
|
This was cherry-picked from rochoa:master |
|
Is it truly important to support node v0.8.x still? |
|
I did the pull request when the README was still stating node v0.8.x was supported. As newer versions, read it as 3.0.0, are not supporting node v0.8.x it probably doesn't make sense to merge in master (#314) but I think it could be nice to have it 1.x series since some people still use v0.8.x. What do you think? |
springmeyer
pushed a commit
that referenced
this pull request
Oct 27, 2014
Don't rely on process.env.hasOwnProperty
|
okay, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't rely on process.env.hasOwnProperty as in Node <0.9.0 versions it doesn't work like a proper JS object.
See: nodejs/node-v0.x-archive#3521