Skip to content

Commit

Permalink
avoid bundling node-pre-gyp
Browse files Browse the repository at this point in the history
  • Loading branch information
Dane Springmeyer committed Apr 6, 2016
1 parent bcd53e7 commit df7d542
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,9 @@
"dependencies": {
"mapnik-vector-tile": "1.0.5",
"nan": "~2.2.0",
"node-pre-gyp": "~0.6.22",
"node-pre-gyp": "~0.6.25",
"protozero": "~1.3.0"
},
"bundledDependencies": [
"mapnik-vector-tile",
"node-pre-gyp"
],
"bin": {
"mapnik-inspect.js": "./bin/mapnik-inspect.js",
"mapnik-render.js": "./bin/mapnik-render.js",
Expand All @@ -58,6 +54,7 @@
"scripts": {
"prepublish": "npm ls",
"test": "jshint bin lib/index.js lib/mapnik.js && mocha -R spec --timeout 50000",
"preinstall":"npm install node-pre-gyp",

This comment has been minimized.

Copy link
@tjwebb

tjwebb May 28, 2016

This is a really bad idea and makes the package impossible to install. Also, node-pre-gyp is already a dependency. See #650

This comment has been minimized.

Copy link
@BHare1985

BHare1985 Jun 21, 2016

I believe I am having an issue with this change: mapbox/node-pre-gyp#220

preinstall and perhaps installs are ran as non-root where as dependency installs run as root. This causes the Amazon Beanstalk deploy to fail for permissions. I am still testing if reverting this commit fixes my issue

"install": "node-pre-gyp install --fallback-to-build",
"docs": "documentation src/*.cpp --polyglot -o documentation -f html --github --name Mapnik"
},
Expand Down

0 comments on commit df7d542

Please sign in to comment.